Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Fix 4.2 release notes rendered display. #16102

Merged
merged 1 commit into from Jul 9, 2014
Merged

[ci skip] Fix 4.2 release notes rendered display. #16102

merged 1 commit into from Jul 9, 2014

Conversation

JuanitoFatas
Copy link
Contributor

Before

screenshot 2014-07-09 15 09 03

screenshot 2014-07-09 15 09 13

screenshot 2014-07-09 15 09 21

After

screenshot 2014-07-09 15 11 57

screenshot 2014-07-09 15 12 02

screenshot 2014-07-09 15 12 13

zzak pushed a commit that referenced this pull request Jul 9, 2014
[ci skip] Fix 4.2 release notes rendered display.
@zzak zzak merged commit a6affcc into rails:master Jul 9, 2014
@JuanitoFatas JuanitoFatas deleted the format-fixes branch July 9, 2014 07:39
@matthewd
Copy link
Member

matthewd commented Jul 9, 2014

This is definitely an improvement... but I think the relevant style guide dictates that the "(Commit)" part should be the last thing in an entry.

And forcing all entries to be a single paragraph (as per the range instance here) doesn't seem a particularly viable solution. 😐

@JuanitoFatas
Copy link
Contributor Author

@matthewd I tried to follow the style. But markdown list item won't line-up. 😢 That's why I make it this way.

@matthewd
Copy link
Member

matthewd commented Jul 9, 2014

Yeah, I guessed so. Did we just not have enough indentation?

List items may consist of multiple paragraphs. Each subsequent paragraph in a list item must be indented by either 4 spaces or one tab

@JuanitoFatas
Copy link
Contributor Author

@matthewd Thanks. I will fix it and raise a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants