New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci skip] Fix list item rendered display of 4.2 release notes. #16154
Conversation
My bad! Should we just do 4 spaces everywhere in this file then? ( |
I think we only need to change when list item has more than one paragraph. So no need to change everywhere. |
Right I understand that it's not necessary, but would it maintain the format we want if we normalize the indentation across this file? (I think changlogs are like that) The reason I ask is that I think it's be much easier for other people to just follow the four spam indentation than to tell everyone about the special rule. And because of the way we work on this file Im not too concerned about populating the git history and I think the benefits outweighed it. Does that make sense? :) |
(That's just for this one file though.) |
@chancancode I'd suggest |
👍 |
I am 👍 on this to prevent further mistakes. I am changing it. |
@chancancode I've updated my commit. Please take a look. Do you mean this way? I checked the output looks good. |
@@ -60,30 +59,30 @@ Please refer to the [Changelog][railties] for detailed changes. | |||
### Removals | |||
|
|||
* The `rails application` command has been removed without replacement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* The ...
([Pull Request...
I added some examples, does it make sense? (Sorry it's a bit hard to do this from mobile) |
Thanks for reviewing from mobile. I think it is good to go now! |
I must have confused you even more with my comments 😄 I fixed it in 9386ddf and credited you. If you found anything else please feel free to open a new PR. |
👍 I was also confused. Thanks! |
I changed this to 4 spaces in #16103 to display correctly.
The reason: List items may consist of multiple paragraphs. Each subsequent paragraph in a list item must be indented by either 4 spaces or one tab.
cc @chancancode