Improve Active Model Dirty API.

[rafaelfranca]

I did some changes on this API:

• reset_changes becomes clear_changes_information. I believe this new name matches with what it is doing.
• reset_* is deprecated in favor of restore_*. This will avoid confusion with the deprecated reset_changes.
• undo_changes is now restore_attributes. To match the behaviour of restore_*.

@dhh @chancancode

[sgrif]

restore_changes feels weird to me, it almost sounds like it's an undo method for the discarding done by clear_changes_information

[chancancode]

def restore_attribute!(attr)? 😄

[chancancode]

nvm 🙈

[rafaelfranca]

restore_values then?

[chancancode]

❤️ 💚 💙 💛 💜

[sgrif]

restore_changed_values to be explicit, maybe?

[chancancode]

How about #restore_attributes? It just occurred to me that when using this method, you are not really thinking about the "changes", but thinking that you'd like to restore your attributes to their previous values (just like when you use restore_name).

As a bonus, it could take a list of attributes for when you want to restrict it to just a subset of possibly-changed-or-not attributes (e.g. def restore_price; restore_attributes(:currency, :price_in_cents); end).

Not sure if "attributes" is what you call them in the Active Model layer though.

[chancancode]

(or restore_changed_attributes, if it's somehow confusing. we already have a changed_attributes so it pairs nicely)

[dhh]

I like restore_attributes and restore_age. Great symmetry and we bind the term "restore" to specifically deal with the dirty state.

[rafaelfranca]

Changed to restore_attributes. Anything else?

[chancancode]

❤️ ! I would like to explore the usefulness of expanding restore_attributes to take an arg list of attributes, but we can discuss more and do that separately later 😄

[bogdan]

good job