Skip to content

assets:clean task now cleans up images #1776

Merged
merged 1 commit into from Jun 20, 2011

2 participants

@jamesarosen

rake assets:clean will now clean up any image files (*.png, *.gif, *.jpg, *.jpeg, *.ico) in addition to CSS and JS.

@jamesarosen

Pull request updated as per #1355 (comment)

@josh josh merged commit 2df2bfd into rails:master Jun 20, 2011
@jamesarosen

Just noticed a slight flaw: if there are subdirectories in public/assets/, you get an Operation not permitted. Either of the following fixes it:

rm file unless File.directory?(file)

or

rm file, :force => true
@josh
Ruby on Rails member
josh commented Jun 20, 2011

Yeah, we need :force to remove the dirs too.

@uchagani uchagani pushed a commit that referenced this pull request Nov 26, 2013
James A. Rosen rake assets:clean also removes directories d26cf14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.