Fix nested fields_for when Hash-based model is passed. #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error when a record object that is a subclass of Hash is passed to fields_for, which is incorrectly interpreted as field options.
| @@ -1689,6 +1689,24 @@ class FormHelperTest < ActionView::TestCase | |||
| assert_dom_equal expected, output_buffer | |||
| end | |||
|
|
|||
| def test_nested_fields_for_with_hash_like_model | |||
There was a problem hiding this comment.
Why not a use a hash in the test?
|
I've updated the test to use a real hash-based model rather than a stubbed out one. |
josevalim
added a commit
that referenced
this pull request
Jun 22, 2011
Fix nested fields_for when Hash-based model is passed.
spastorino
added a commit
that referenced
this pull request
Jul 6, 2011
Backport of #1778 (fix nested fields_for when Hash-based model is passed)
sterrym
pushed a commit
to sterrym/formtastic
that referenced
this pull request
Jan 31, 2014
Thanks to @rafaelfranca and @spohlenz fixing in simple_form and Rails! See: heartcombo/simple_form@14b6263 rails/rails#1778 ref formtastic#568
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error when a record object that is a subclass of Hash is passed to fields_for, which is incorrectly interpreted as field options.