Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log instrumentation name for exists? queries #1823

Merged
merged 1 commit into from Jul 11, 2011
Merged

Conversation

gnarg
Copy link

@gnarg gnarg commented Jun 22, 2011

Hi,

I noticed that as of 3.1 exists? queries stopped reporting an instrumentation name in their log entry. Here's a proposed patch for that.

Thanks,
Jon
Ruby Agent Engineer
New Relic

@sikachu
Copy link
Member

sikachu commented Jun 22, 2011

Looks good. @tenderlove do you mind picking this in? (If all the tests passed?)

@pixeltrix
Copy link
Contributor

It stopped being reported a long time ago.

@sikachu
Copy link
Member

sikachu commented Jun 22, 2011

Nice find! haha

@ghost ghost assigned pixeltrix Jun 22, 2011
jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011
…ven after a call to session_reset [rails#1823 state:resolved]

Signed-off-by: Joshua Peek <josh@joshpeek.com>
spastorino added a commit that referenced this pull request Jul 11, 2011
Log instrumentation name for exists? queries
@spastorino spastorino merged commit c3732bf into rails:master Jul 11, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants