Remove ActionController::HideActions (closes #18336) #18371

Merged
merged 1 commit into from Jan 8, 2015

Conversation

Projects
None yet
2 participants
@brainopia
Contributor

brainopia commented Jan 6, 2015

cc @dhh

@brainopia

This comment has been minimized.

Show comment
Hide comment
@brainopia

brainopia Jan 8, 2015

Contributor

@dhh Hello, David. If there is anything you'd like to see changed in pull-request, I'd be happy to be of service.

Contributor

brainopia commented Jan 8, 2015

@dhh Hello, David. If there is anything you'd like to see changed in pull-request, I'd be happy to be of service.

@dhh

This comment has been minimized.

Show comment
Hide comment
@dhh

dhh Jan 8, 2015

Member

We were thinking about whether there were any consequences for ActionMailer etc, but let's just proceed with this for now, and we can follow up if there's any fallout. Thanks for working on this! It's great to prune the dead branches off the tree.

Member

dhh commented Jan 8, 2015

We were thinking about whether there were any consequences for ActionMailer etc, but let's just proceed with this for now, and we can follow up if there's any fallout. Thanks for working on this! It's great to prune the dead branches off the tree.

dhh added a commit that referenced this pull request Jan 8, 2015

Merge pull request #18371 from brainopia/remove_hide_actions
Remove ActionController::HideActions (closes #18336)

@dhh dhh merged commit 46c853f into rails:master Jan 8, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

iamvery added a commit to iamvery/pundit that referenced this pull request Feb 2, 2016

Replace calls to `hide_action` with protected access modifier
* Rails 5 beta removes this interface
  rails/rails#18371
* Using protected over private so that subclasses of the including class
  may still access these methods.
* Since these methods are called directly in test, we raise the access
  modifier to public for them to preserve the test behavior.

yusabana added a commit to 1pac/trice that referenced this pull request Sep 29, 2016

Above activesupport5 support
* Adjust trice.gemspec.
* Removed hide_action method. [rails/rails#18371](rails/rails#18371)
* Defined helper_method as private instead of hide_action. [rails/rails#18336](rails/rails#18336)
* Add rails-controller-testing gem.

yusabana added a commit to 1pac/trice that referenced this pull request Sep 29, 2016

Support above activesupport5
* Adjust trice.gemspec.
* Removed hide_action method. [rails/rails#18371](rails/rails#18371)
* Defined helper_method as private instead of hide_action. [rails/rails#18336](rails/rails#18336)
* Add rails-controller-testing gem.

yusabana added a commit to 1pac/trice that referenced this pull request Sep 29, 2016

Support above activesupport5
* Adjust trice.gemspec.
* Removed hide_action method.  refs: rails/rails#18371
* Defined helper_method as private instead of hide_action. refs: rails/rails#18336
* Add rails-controller-testing gem.

yusabana added a commit to 1pac/trice that referenced this pull request Sep 30, 2016

Support above activesupport5
* Adjust trice.gemspec.
* Removed hide_action method.  refs: rails/rails#18371
* Defined helper_method as private instead of hide_action. refs: rails/rails#18336
* Add rails-controller-testing gem.

@yusabana yusabana referenced this pull request in cookpad/trice Oct 1, 2016

Merged

Support activesupport5 #15

skalee added a commit to riboseinc/synced_resources that referenced this pull request Oct 18, 2017

Remove #hide_action method calls
The ActionController::HideActions module has been removed from Rails as
of 5.0.  The #hide_action method wasn't very useful, though.  The effect
was basically equivalent to making a method private.

See:
- varvet/pundit#23 (comment)
- rails/rails#18336
- rails/rails#18371

@skalee skalee referenced this pull request in riboseinc/synced_resources Oct 18, 2017

Merged

Remove #hide_action method calls #21

skalee added a commit to riboseinc/synced_resources that referenced this pull request Oct 18, 2017

Remove #hide_action method calls
The ActionController::HideActions module has been removed from Rails as
of 5.0.  The #hide_action method wasn't very useful, though.  The effect
was basically equivalent to making a method private.

See:
- varvet/pundit#23 (comment)
- rails/rails#18336
- rails/rails#18371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment