Remove ActionController::HideActions (closes #18336) #18371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainopia
force-pushed
the
remove_hide_actions
branch
from
3376e51
to
08d3f0e
Compare
|
@dhh Hello, David. If there is anything you'd like to see changed in pull-request, I'd be happy to be of service. |
|
We were thinking about whether there were any consequences for ActionMailer etc, but let's just proceed with this for now, and we can follow up if there's any fallout. Thanks for working on this! It's great to prune the dead branches off the tree. |
dhh
added a commit
that referenced
this pull request
Jan 8, 2015
Remove ActionController::HideActions (closes #18336)
iamvery
added a commit
to iamvery/pundit
that referenced
this pull request
Feb 2, 2016
* Rails 5 beta removes this interface rails/rails#18371 * Using protected over private so that subclasses of the including class may still access these methods. * Since these methods are called directly in test, we raise the access modifier to public for them to preserve the test behavior.
takaesu-ug
added a commit
to 1pac/trice
that referenced
this pull request
Sep 29, 2016
* Adjust trice.gemspec. * Removed hide_action method. [rails/rails#18371](rails/rails#18371) * Defined helper_method as private instead of hide_action. [rails/rails#18336](rails/rails#18336) * Add rails-controller-testing gem.
takaesu-ug
added a commit
to 1pac/trice
that referenced
this pull request
Sep 29, 2016
* Adjust trice.gemspec. * Removed hide_action method. [rails/rails#18371](rails/rails#18371) * Defined helper_method as private instead of hide_action. [rails/rails#18336](rails/rails#18336) * Add rails-controller-testing gem.
takaesu-ug
added a commit
to 1pac/trice
that referenced
this pull request
Sep 29, 2016
* Adjust trice.gemspec. * Removed hide_action method. refs: rails/rails#18371 * Defined helper_method as private instead of hide_action. refs: rails/rails#18336 * Add rails-controller-testing gem.
takaesu-ug
added a commit
to 1pac/trice
that referenced
this pull request
Sep 30, 2016
* Adjust trice.gemspec. * Removed hide_action method. refs: rails/rails#18371 * Defined helper_method as private instead of hide_action. refs: rails/rails#18336 * Add rails-controller-testing gem.
skalee
added a commit
to riboseinc/synced_resources
that referenced
this pull request
Oct 18, 2017
The ActionController::HideActions module has been removed from Rails as of 5.0. The #hide_action method wasn't very useful, though. The effect was basically equivalent to making a method private. See: - varvet/pundit#23 (comment) - rails/rails#18336 - rails/rails#18371
skalee
added a commit
to riboseinc/synced_resources
that referenced
this pull request
Oct 18, 2017
The ActionController::HideActions module has been removed from Rails as of 5.0. The #hide_action method wasn't very useful, though. The effect was basically equivalent to making a method private. See: - varvet/pundit#23 (comment) - rails/rails#18336 - rails/rails#18371
HappyDevman
added a commit
to HappyDevman/pundit
that referenced
this pull request
May 5, 2021
* Rails 5 beta removes this interface rails/rails#18371 * Using protected over private so that subclasses of the including class may still access these methods. * Since these methods are called directly in test, we raise the access modifier to public for them to preserve the test behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @dhh