Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ActionController::HideActions (closes #18336) #18371

Merged
merged 1 commit into from Jan 8, 2015

Conversation

brainopia
Copy link
Contributor

@brainopia brainopia commented Jan 6, 2015

cc @dhh

@brainopia
Copy link
Contributor Author

brainopia commented Jan 8, 2015

@dhh Hello, David. If there is anything you'd like to see changed in pull-request, I'd be happy to be of service.

@dhh
Copy link
Member

dhh commented Jan 8, 2015

We were thinking about whether there were any consequences for ActionMailer etc, but let's just proceed with this for now, and we can follow up if there's any fallout. Thanks for working on this! It's great to prune the dead branches off the tree.

dhh added a commit that referenced this pull request Jan 8, 2015
Remove ActionController::HideActions (closes #18336)
@dhh dhh merged commit 46c853f into rails:master Jan 8, 2015
iamvery added a commit to iamvery/pundit that referenced this pull request Feb 2, 2016
* Rails 5 beta removes this interface
  rails/rails#18371
* Using protected over private so that subclasses of the including class
  may still access these methods.
* Since these methods are called directly in test, we raise the access
  modifier to public for them to preserve the test behavior.
yusabana added a commit to 1pac/trice that referenced this pull request Sep 29, 2016
* Adjust trice.gemspec.
* Removed hide_action method. [rails/rails#18371](rails/rails#18371)
* Defined helper_method as private instead of hide_action. [rails/rails#18336](rails/rails#18336)
* Add rails-controller-testing gem.
yusabana added a commit to 1pac/trice that referenced this pull request Sep 29, 2016
* Adjust trice.gemspec.
* Removed hide_action method. [rails/rails#18371](rails/rails#18371)
* Defined helper_method as private instead of hide_action. [rails/rails#18336](rails/rails#18336)
* Add rails-controller-testing gem.
yusabana added a commit to 1pac/trice that referenced this pull request Sep 29, 2016
* Adjust trice.gemspec.
* Removed hide_action method.  refs: rails/rails#18371
* Defined helper_method as private instead of hide_action. refs: rails/rails#18336
* Add rails-controller-testing gem.
yusabana added a commit to 1pac/trice that referenced this pull request Sep 30, 2016
* Adjust trice.gemspec.
* Removed hide_action method.  refs: rails/rails#18371
* Defined helper_method as private instead of hide_action. refs: rails/rails#18336
* Add rails-controller-testing gem.
skalee added a commit to riboseinc/synced_resources that referenced this pull request Oct 18, 2017
The ActionController::HideActions module has been removed from Rails as
of 5.0.  The #hide_action method wasn't very useful, though.  The effect
was basically equivalent to making a method private.

See:
- varvet/pundit#23 (comment)
- rails/rails#18336
- rails/rails#18371
skalee added a commit to riboseinc/synced_resources that referenced this pull request Oct 18, 2017
The ActionController::HideActions module has been removed from Rails as
of 5.0.  The #hide_action method wasn't very useful, though.  The effect
was basically equivalent to making a method private.

See:
- varvet/pundit#23 (comment)
- rails/rails#18336
- rails/rails#18371
HappyDevman added a commit to HappyDevman/pundit that referenced this pull request May 5, 2021
* Rails 5 beta removes this interface
  rails/rails#18371
* Using protected over private so that subclasses of the including class
  may still access these methods.
* Since these methods are called directly in test, we raise the access
  modifier to public for them to preserve the test behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants