TransactionManager should call rollback records #18614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurnn
force-pushed
the
rollback_records_parity
branch
from
2951da0
to
2e85224
Compare
rafaelfranca
added a commit
that referenced
this pull request
Jan 20, 2015
TransactionManager should call rollback records
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed previously the transaction object should not call
commit_recordsorrollback_records. TransactionManager should be the one that commit/rollback the records.commit_recordswas moved to the transaction manager layer on #18458. This movesrollback_recordstoo.review @jeremy @brainopia