Fix dependency tracker bug #19074
Merged
Fix dependency tracker bug #19074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| template = FakeTemplate.new("<%# render partial: 'messages/show', layout: 'messages/layout' %>", :erb) | ||
| tracker = make_tracker("multiple/_dependencies", template) | ||
|
|
||
| assert_equal ["messages/layout", "messages/show"], tracker.dependencies | ||
| assert_equal ["messages/show", "messages/layout"], tracker.dependencies |
There was a problem hiding this comment.
Does this test fail with your change or are you just changing the test to match your change? If it's the former - I think both ways would need to pass. If it's the latter let's leave the original test as is and create a second test. Let me know if I am not understanding the issue as it's very early where I am 😉 ☕
There was a problem hiding this comment.
@eileencodes I changed my code to work with the original test.
|
Is this related to any issue? Just to know if the issue will be closed |
|
I'm not sure, I don't think so. I found it by searching for 'FIXME' inside Rails source code. |
|
Right. Thanks |
rafaelfranca
added a commit
that referenced
this pull request
Feb 25, 2015
…plate_partial_with_layout Fix dependency tracker bug
Mession
deleted the
fix_test_dependency_of_erb_template_partial_with_layout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a dependency tracker bug that caused template dependencies not count layouts as dependencies for partials.