Run ActionPack test cases in random order. #19217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senny
added a commit
that referenced
this pull request
Mar 5, 2015
…m_order Run ActionPack test cases in random order.
|
@tgxworld let's do it 👍 |
|
@senny That was quick 😄 Thanks! |
|
Oh, yes. We should revert all the ones that were briefly set to random. The plan was to do that after we forked 4-2-stable. 😳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured we should start incrementally run the internal test cases in random order. We can't fix/identify tests that modifies global state if we don't run it. Furthermore, most of the ActionPack tests were already fixed in GSoC 2014.
Just in case, I ran the tests on my local machine 'ALOT' of times.
https://gist.github.com/tgxworld/245cb2fada81a514f6ae
cc/ @senny WDYT?