Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all our tests in random order #19221

Merged
merged 2 commits into from Mar 6, 2015
Merged

Run all our tests in random order #19221

merged 2 commits into from Mar 6, 2015

Conversation

matthewd
Copy link
Member

@matthewd matthewd commented Mar 5, 2015

My recollection is that this was mostly working, but we were seeing just enough failures that we didn't want to leave it enabled while branching for release.

Let's see whether that's (still) true.

See also #19217.

/cc @tgxworld

@matthewd
Revert "Leave all our tests as order_dependent! for now"
b5eb0b6 
This reverts commit 2f52f96.

Conflicts:
	actionmailer/test/abstract_unit.rb
	actionview/test/abstract_unit.rb
	activemodel/test/cases/helper.rb
	activerecord/test/cases/helper.rb
	activesupport/test/abstract_unit.rb
	railties/test/abstract_unit.rb
@matthewd
Revert "For now, we will keep sorting the tests."
e462021 
This reverts commit 7025d77.
@senny
Copy link
Member

senny commented Mar 5, 2015

@matthewd does that work for AR? I suspect there is still work left to do before those pass at a reasonable rate.

@jeremy
Copy link
Member

jeremy commented Mar 5, 2015

🤘

@tgxworld
Copy link
Contributor

tgxworld commented Mar 6, 2015

@senny, @amatsuda was the last one working on. If I remember correctly, failures came from AR. 😄

@amatsuda
Copy link
Member

amatsuda commented Mar 6, 2015

Yeah, as far as I remember, there remains some sporadic fails in AR suites, about which nobody cares at all while we're running tests in :sorted order.
I'm still willing to track the CI failures on AR, so I add 👍 from me. Thanks @matthewd for reminding the issue.

senny added a commit that referenced this pull request Mar 6, 2015
@senny
tests, remove side effects on Joke during base_test.rb.
eac3349 
prompted by #19221.
matthewd added a commit that referenced this pull request Mar 6, 2015
@matthewd
Merge pull request #19221 from matthewd/random-tests
c96cb66 
Run all our tests in random order
@matthewd matthewd merged commit c96cb66 into rails:master Mar 6, 2015
@rafaelfranca
Copy link
Member

❤️ 💚 💙 💛 💜

@tgxworld
Copy link
Contributor

tgxworld commented Mar 6, 2015

👍

@tgxworld tgxworld mentioned this pull request Mar 23, 2015
Merged
@matthewd matthewd deleted the random-tests branch August 22, 2015 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@matthewd @senny @jeremy @tgxworld @amatsuda @rafaelfranca