Added note about non-GET links getting converted to GET links in mailer Added note about non-GET links getting converted to GET links in mailer templates [ci skip] #19931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
//cc @senny
|
|
@prathamesh-sonpatki can you format the note so that it will put the text into the yellow box? I think it's:
|
prathamesh-sonpatki
force-pushed
the
note-about-non-get-links
branch
from
68e5b39
to
d27cd9b
Compare
|
Done. |
| @@ -530,6 +530,8 @@ url helper. | |||
| <%= user_url(@user, host: 'example.com') %> | |||
| ``` | |||
|
|
|||
| NOTE: `non-GET` links don't work when added to mailer templates. They are treated as `GET` links. | |||
There was a problem hiding this comment.
What do you think about?
non-GET links require JavaScript and won't work in mailer templates. They will result in normal GET requests.
There was a problem hiding this comment.
@senny Should we mention jQuery UJS instead of JavaScript? Rest of the sentence looks good to me.
There was a problem hiding this comment.
@prathamesh-sonpatki yea that's probably better. You can even link the word to the project https://github.com/rails/jquery-ujs
…ler templates [ci skip]
prathamesh-sonpatki
force-pushed
the
note-about-non-get-links
branch
from
d27cd9b
to
3d92a9e
Compare
|
@senny updated. |
senny
added a commit
that referenced
this pull request
Apr 28, 2015
…-links Added note about non-GET links getting converted to GET links in mailer Added note about non-GET links getting converted to GET links in mailer templates [ci skip]
senny
added a commit
that referenced
this pull request
Apr 28, 2015
…-links Added note about non-GET links getting converted to GET links in mailer Added note about non-GET links getting converted to GET links in mailer templates [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.