write_cookies! in ActionDispatch::TestRequest won't write nil value

[bfolkens]

Rack::Utils.escape(str) breaks when cookie value is nil.

NoMethodError: private method `gsub' called for nil:NilClass
    activesupport (3.1.0.rc4) lib/active_support/whiny_nil.rb:48:in `method_missing'
    rack (1.3.1) lib/rack/backports/uri/common.rb:24:in `encode_www_form_component'
    rack (1.3.1) lib/rack/utils.rb:23:in `escape'
    actionpack (3.1.0.rc4) lib/action_dispatch/testing/test_request.rb:86:in `escape_cookie'
    actionpack (3.1.0.rc4) lib/action_dispatch/testing/test_request.rb:81:in `write_cookies!'

[spastorino]

We need a test case in order to merge this. Thanks.

[pixeltrix]

The test is a bit implementation specific - personally I'd prefer it if just tests that setting a cookie to a nil value doesn't raise an error

[spastorino]

Agree with @pixeltrix, also we need one commit for the tests + patch, can you check if it doesn't raise and squash the commits into one?

[bfolkens]

Sorry, looks like this one got closed out automatically