Avoid crashing when minitest-rails is loaded. #20747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The improvments to the test runner's integration with minitest in commit b6fc8e2 add methods to the Minitest module that refer to the Rails module. Unfortunately, when the minitest-rails gem is loaded, the reference is incorrectly resolved to the Minitest::Rails module.
kaspth
added a commit
that referenced
this pull request
Jul 1, 2015
Avoid crashing when minitest-rails is loaded.
|
Oops, thanks for helping us out ❤️ |
|
@kaspth Thank you for the fast turnaround! FWIW, I'm glad things happened this way. I got to learn that "rails test" now runs tests by line number. I really ❤️ that feature! Great work! |
|
No problem, and thanks :) Kasper On 1. jul. 2015 13.46 +0200, Victor Costannotifications@github.com, wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improvments to the test runner's integration with minitest in commit b6fc8e2 add methods to the Minitest module that refer to the Rails module. Unfortunately, when the minitest-rails gem is loaded, the reference is incorrectly resolved to the Minitest::Rails module.
I fixed this by switching those references to absolute references. I'm not sure how to add tests for this change, but I tested it manually and it works with the
rails5branch of minitest-rails.