Fix and Improve sql logging coloration in ActiveRecord::LogSubscriber
.
#20921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Would be colored as MAGENTA in the existing code.
payload[:name]
via new method:colorize_payload_name
Instead of simple alternating colors, adds meaning:
MAGENTA
for"SQL"
orblank?
payload namesCYAN
for Model Load/ExistsActiveRecord::LogSubscriber
instance methods private for clarity:colorize_payload_name
sql_color
logger
GH #20885