Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to get a running custom base controller #21008

Merged
merged 1 commit into from Aug 1, 2015

Conversation

svenwin
Copy link
Contributor

@svenwin svenwin commented Jul 23, 2015

While trying to build a custom ApplicationController without certain modules (via #without_modules) I learned that you had to subclass ActionController::Metal in order to have config_accessor and other things in place.

This minimal documentation change reflects this.

@svenwin
Copy link
Contributor Author

svenwin commented Jul 23, 2015

@repinel this is the follow up to GH-20609.

@repinel
Copy link
Member

repinel commented Jul 23, 2015

@svenwin Thanks for adding the tag. You could have amended the commit and forced push to the branch.

senny added a commit that referenced this pull request Aug 1, 2015
Add documentation to get a running custom base controller [ci skip]
@senny senny merged commit 7c5e422 into rails:master Aug 1, 2015
senny added a commit that referenced this pull request Aug 1, 2015
Add documentation to get a running custom base controller [ci skip]
@senny
Copy link
Member

senny commented Aug 1, 2015

@svenwin thank you 💛

I changed the class name to MyBaseController and updated the with_modules documentation for the API controller was well (21b870c)

senny added a commit that referenced this pull request Aug 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants