Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate si prefix #21191

Merged
merged 2 commits into from
Aug 11, 2015
Merged

Deprecate si prefix #21191

merged 2 commits into from
Aug 11, 2015

Conversation

byroot
Copy link
Member

@byroot byroot commented Aug 11, 2015

As discussed a while ago in #7835 (comment)

cc @rafaelfranca

rafaelfranca
rafaelfranca reviewed Aug 11, 2015
View reviewed changes
activesupport/test/number_helper_test.rb
@@ -233,19 +233,6 @@ def test_number_number_to_human_size
end
end

def test_number_to_human_size_with_si_prefix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to keep the tests and use assert_deprecated block just to make sure we don't break the deprecated code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of assert_deprecated. I'll update thanks.

rafaelfranca added a commit that referenced this pull request Aug 11, 2015
@rafaelfranca
Merge pull request #21191 from byroot/deprecate-si-prefix
b864641 
Deprecate si prefix
@rafaelfranca rafaelfranca merged commit b864641 into rails:master Aug 11, 2015
@repinel repinel mentioned this pull request Aug 13, 2015
Merged
y-yagi added a commit to y-yagi/rails that referenced this pull request Jun 9, 2016
@y-yagi
remove deprecated :prefix option from doc [ci skip]
8cafa57 
The option was deprecated in rails#21191.
@y-yagi y-yagi mentioned this pull request Jun 9, 2016
Merged
@hakanai
Copy link

hakanai commented Aug 2, 2016

Hang on, but isn't it still formatting questionably by default in v5.0.0?

irb(main):001:0> include ActionView::Helpers::NumberHelper
=> Object
irb(main):002:0> number_to_human_size(1000000)
=> "977 KB"

I'd expect either "1000 kB" or "1 MB" and wouldn't mind removal of the option if the default behaviour had been correct in the first place...

I can understand not wanting "kiB", "MiB" and the like since not everyone will have seen those before and very few apps would need to use them anyway, but can't we at least have "kB", "MB" and so on computed correctly? If the method is supposed to produce a "human" size, why is it using the base 2 definition of the units?

@rafaelfranca rafaelfranca mentioned this pull request Apr 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byroot @hakanai @rafaelfranca