New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate si prefix #21191

Merged
merged 2 commits into from Aug 11, 2015

Conversation

Projects
None yet
3 participants
@byroot
Member

byroot commented Aug 11, 2015

As discussed a while ago in #7835 (comment)

cc @rafaelfranca

rafaelfranca added a commit that referenced this pull request Aug 11, 2015

@rafaelfranca rafaelfranca merged commit b864641 into rails:master Aug 11, 2015

y-yagi added a commit to y-yagi/rails that referenced this pull request Jun 9, 2016

@trejkaz

This comment has been minimized.

Show comment
Hide comment
@trejkaz

trejkaz Aug 2, 2016

Hang on, but isn't it still formatting questionably by default in v5.0.0?

irb(main):001:0> include ActionView::Helpers::NumberHelper
=> Object
irb(main):002:0> number_to_human_size(1000000)
=> "977 KB"

I'd expect either "1000 kB" or "1 MB" and wouldn't mind removal of the option if the default behaviour had been correct in the first place...

I can understand not wanting "kiB", "MiB" and the like since not everyone will have seen those before and very few apps would need to use them anyway, but can't we at least have "kB", "MB" and so on computed correctly? If the method is supposed to produce a "human" size, why is it using the base 2 definition of the units?

trejkaz commented Aug 2, 2016

Hang on, but isn't it still formatting questionably by default in v5.0.0?

irb(main):001:0> include ActionView::Helpers::NumberHelper
=> Object
irb(main):002:0> number_to_human_size(1000000)
=> "977 KB"

I'd expect either "1000 kB" or "1 MB" and wouldn't mind removal of the option if the default behaviour had been correct in the first place...

I can understand not wanting "kiB", "MiB" and the like since not everyone will have seen those before and very few apps would need to use them anyway, but can't we at least have "kB", "MB" and so on computed correctly? If the method is supposed to produce a "human" size, why is it using the base 2 definition of the units?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment