Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate si prefix #21191

Merged
merged 2 commits into from Aug 11, 2015
Merged

Deprecate si prefix #21191

merged 2 commits into from Aug 11, 2015

Conversation

@byroot
Copy link
Member

@byroot byroot commented Aug 11, 2015

As discussed a while ago in #7835 (comment)

cc @rafaelfranca

@@ -233,19 +233,6 @@ def test_number_number_to_human_size
end
end

def test_number_to_human_size_with_si_prefix

This comment has been minimized.

@rafaelfranca

rafaelfranca Aug 11, 2015
Member

I think it is better to keep the tests and use assert_deprecated block just to make sure we don't break the deprecated code.

This comment has been minimized.

@byroot

byroot Aug 11, 2015
Author Member

I wasn't aware of assert_deprecated. I'll update thanks.

@byroot byroot force-pushed the byroot:deprecate-si-prefix branch from 6bb020b to e96403b Aug 11, 2015
rafaelfranca added a commit that referenced this pull request Aug 11, 2015
Deprecate si prefix
@rafaelfranca rafaelfranca merged commit b864641 into rails:master Aug 11, 2015
y-yagi added a commit to y-yagi/rails that referenced this pull request Jun 9, 2016
@trejkaz
Copy link

@trejkaz trejkaz commented Aug 2, 2016

Hang on, but isn't it still formatting questionably by default in v5.0.0?

irb(main):001:0> include ActionView::Helpers::NumberHelper
=> Object
irb(main):002:0> number_to_human_size(1000000)
=> "977 KB"

I'd expect either "1000 kB" or "1 MB" and wouldn't mind removal of the option if the default behaviour had been correct in the first place...

I can understand not wanting "kiB", "MiB" and the like since not everyone will have seen those before and very few apps would need to use them anyway, but can't we at least have "kB", "MB" and so on computed correctly? If the method is supposed to produce a "human" size, why is it using the base 2 definition of the units?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.