New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dropping indexes concurrently in Postgres #21317

Merged
merged 1 commit into from Sep 6, 2015

Conversation

Projects
None yet
2 participants
@greysteil
Contributor

greysteil commented Aug 21, 2015

Adds support for dropping a Postgres index concurrently, with the same API as adding one concurrently.
See http://www.postgresql.org/docs/9.4/static/sql-dropindex.html for more details.

@greysteil

This comment has been minimized.

Show comment
Hide comment
@greysteil

greysteil Sep 5, 2015

Contributor

@senny - could you suggest someone to review this?

Contributor

greysteil commented Sep 5, 2015

@senny - could you suggest someone to review this?

@matthewd matthewd merged commit ce17e23 into rails:master Sep 6, 2015

matthewd added a commit that referenced this pull request Sep 6, 2015

Merge pull request #21317 from greysteil/support-postgres-drop-index-…
…concurrently

Support dropping indexes concurrently in Postgres

matthewd added a commit that referenced this pull request Sep 6, 2015

Fix test failures from premature merge of #21317
Apparently I managed to forget how similar the "tests passing" and
"no status reported" merge indicators look.

Note that the previous `stubs` in test_add_index wasn't working:
the method was still called, and just happened to return false.

yahonda added a commit to yahonda/activerecord-jdbc-adapter that referenced this pull request Oct 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment