Deprecate passing conditions to AR::Relation destroy_all and delete_all methods #21505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matthewd (@rails-bot has picked a reviewer for you, use r? to override) |
| # Person.where(age: 0..18).destroy_all | ||
| def destroy_all(conditions = nil) | ||
| if conditions | ||
| ActiveSupport::Deprecation.warn(<<-MESSAGE.squish) | ||
| Passing conditions to destroy_all is deprecated and will be removed in Rails 5.1. | ||
| To achieve the same use where(#{conditions}).destroy_all |
There was a problem hiding this comment.
Let's just use conditions instead of #{conditions}. Interpolation will introduce quoting issues, and could mess up the formatting of the message.
morgoth
force-pushed
the
deprecate-passing-conditions-to-destroy_all-and-delete_all
branch
from
a649daa
to
c82c5f8
Compare
matthewd
added a commit
that referenced
this pull request
Sep 6, 2015
…o-destroy_all-and-delete_all Deprecate passing conditions to AR::Relation destroy_all and delete_all methods
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #21491 (comment) by @matthewd and @sgrif