Added missing specs for not modifying queues when using AJ test helpers #21904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
| @@ -308,9 +304,9 @@ def clear_performed_jobs # :nodoc: | |||
|
|
|||
| def enqueued_jobs_size(only: nil) # :nodoc: | |||
| if only | |||
| enqueued_jobs.select { |job| Array(only).include?(job.fetch(:job)) }.size | |||
| enqueued_jobs.count { |job| Array(only).include?(job.fetch(:job)) } | |||
There was a problem hiding this comment.
Is this done for a perf optimization or is it critical to the code path? It would be better to not include refactoring to keep the blame clean.
There was a problem hiding this comment.
Just a refactoring - probably it will stay like this forever otherwise ;-)
There was a problem hiding this comment.
@schneems Should I change it back?
There was a problem hiding this comment.
It's minimal enough. In the future though we generally ask for refactoring to be removed. It makes history difficult to reason about.
|
@seuros looks like you've touched this method before. Thoughts? |
|
@schneems This change looks good to me. |
|
Thanks ❤️ |
schneems
added a commit
that referenced
this pull request
Oct 7, 2015
…queues Added missing specs for not modifying queues when using AJ test helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why
ensurestatements were needed hererails/activejob/lib/active_job/test_helper.rb
Lines 245 to 247 in e70ec9e
I added missing test for this case and also changed implementation to little more readable (in my opinion at least ;-)) as it's not messing with clearing/restoring the queue