Log job arguments at debug level

[owenbendavies]

On a production system logging all parameters at info level is an
excessive amount of data. Also jobs might contain sensitive information
which does not want to be logged. See:

https://github.com/plataformatec/devise#password-reset-tokens-and-rails-logs

This continues to log job status updates at info level, but logs the job
parameters at debug level.

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @arthurnn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[rafaelfranca]

Looks good to me.

r? @jeremy WDYT?

[owenbendavies]

Is there anything else that is needed for this pull request? Thanks.

[arthurnn]

👍

[monfresh]

I just submitted a similar pull request, but with a different approach: #23031

In my opinion, sensitive information should not be passed in as a job argument in the first place, but in the case where you don't have easy control over that (such as with the Devise reset_password_token), then I think a global setting that determines whether or not arguments are logged can be set to false, and that way sensitive info is not logged regardless of the log level.

What do you think?

[owenbendavies]

I like the idea of making it configurable. I think the default should be to not log, as I prefer security by default and most projects contain sensitive information.

[owenbendavies]

Is there anything I need to do to get this merged? Thanks.

[owenbendavies]

No reply in 8 months so closing :(