Add thread_m/cattr_accessor/reader/writer suite of methods for declaring class and module variables that live per-thread #22630
Conversation
…ing class and module variables that live per-thread
Add thread_m/cattr_accessor/reader/writer suite of methods for declaring class and module variables that live per-thread
| raise NameError.new("invalid attribute name: #{sym}") unless sym =~ /^[_A-Za-z]\w*$/ | ||
| class_eval(<<-EOS, __FILE__, __LINE__ + 1) | ||
| def self.#{sym}=(obj) | ||
| Thread.current[:"attr_#{name}_#{sym}"] = obj |
There was a problem hiding this comment.
I think you want to use thread_variable_get here
There was a problem hiding this comment.
Nice. Didn't even see those had been added. Using those instead.
There was a problem hiding this comment.
I'm pretty sure we don't want those. The fiber methods got the short name because they're the ones that people actually want 99% of the time... if you're not doing something very particular, what you really want is a "current-execution-stack-local" variable, and that's what fiber-locals give you.
As I confusingly mis-stated [and then corrected] around #19693 (comment), our existing internal usage is in PerThreadRegistry, which is actually per-fiber.
So, I think 301f438 should be reverted.
|
Anyone knows any reason why |
Implementation of #19693.