Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Namibia to Timezones. #23036

Closed
wants to merge 1 commit into from
Closed

Add Namibia to Timezones. #23036

wants to merge 1 commit into from

Conversation

manfrin
Copy link

@manfrin manfrin commented Jan 12, 2016

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@thomasfedb
Copy link
Contributor

Looks like a straightforward change. CI failure appears to be unrelated.

@maclover7
Copy link
Contributor

Please rebase - there were CI failures on master yesterday.

@vipulnsward
Copy link
Member

AFAIK, adding new timezones has been frozen. cc @pixeltrix

@matthewd
Copy link
Member

It looks like the correct name would be Windhoek: apart from the major regional TZs, I believe the only departures from the "capital city" rule are islands. (But yes, per #10276, we're reluctant to keep maintaining this list.)

@rafaelfranca
Copy link
Member

#22440 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants