Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing author name [ci skip] #23653

Merged
merged 1 commit into from Feb 13, 2016

Conversation

kamipo
Copy link
Member

@kamipo kamipo commented Feb 13, 2016

The author name was lost in the merge commit 6fedc7d.

The author name was lost in the merge commit 6fedc7d.
@rails-bot
Copy link

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

vipulnsward added a commit that referenced this pull request Feb 13, 2016
Add the missing author name [ci skip]
@vipulnsward vipulnsward merged commit e183227 into rails:master Feb 13, 2016
@vipulnsward
Copy link
Member

Thanks @kamipo !

I believe you are already added to docrails repo(If not, ping @rafaelfranca ), you can send doc changes directly there.

P.S: CHANGELOG should not be changed on Docrails. Mentioning the above, because you send many fixes.

@kamipo kamipo deleted the add_missing_author_name branch February 13, 2016 10:56
@kamipo
Copy link
Member Author

kamipo commented Feb 13, 2016

Thanks. It seems I have not been added to docrails repo.

@maclover7 maclover7 added the docs label Feb 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants