New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `#on_weekday?` method to `Date`, `Time`, and `DateTime`. #23687

Merged
merged 1 commit into from Feb 15, 2016

Conversation

Projects
None yet
4 participants
@vipulnsward
Member

vipulnsward commented Feb 15, 2016

r? @dhh

dhh added a commit that referenced this pull request Feb 15, 2016

Merge pull request #23687 from vipulnsward/add-on-weekday
Add `#on_weekday?` method to `Date`, `Time`, and `DateTime`.

@dhh dhh merged commit 587d70a into rails:master Feb 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dhh

This comment has been minimized.

Show comment
Hide comment
@dhh

dhh Feb 15, 2016

Member

💪

Member

dhh commented Feb 15, 2016

💪

@vijaydev

This comment has been minimized.

Show comment
Hide comment
Member

vijaydev commented Feb 15, 2016

@@ -705,7 +705,7 @@ Please refer to the [Changelog][active-support] for detailed changes.
* Changed the default test order from `:sorted` to `:random`.
([commit](https://github.com/rails/rails/commit/5f777e4b5ee2e3e8e6fd0e2a208ec2a4d25a960d))
* Added `#on_weekend?`, `#next_weekday`, `#prev_weekday` methods to `Date`,
* Added `#on_weekend?`, `#on_weekday?`, `#next_weekday`, `#prev_weekday` methods to `Date`,
`Time`, and `DateTime`.
([Pull Request](https://github.com/rails/rails/pull/18335))

This comment has been minimized.

@vijaydev

vijaydev Feb 15, 2016

Member

We can add this PR link (23687) in the release notes too. The PR 18335 doesn't add on_weekday.

@vijaydev

vijaydev Feb 15, 2016

Member

We can add this PR link (23687) in the release notes too. The PR 18335 doesn't add on_weekday.

This comment has been minimized.

@vipulnsward

vipulnsward Feb 15, 2016

Member

Will do.

On Monday 15 February 2016, Vijay Dev notifications@github.com wrote:

In guides/source/5_0_release_notes.md
#23687 (comment):

@@ -705,7 +705,7 @@ Please refer to the [Changelog][active-support] for detailed changes.

  • Changed the default test order from :sorted to :random.
    (commit)

-* Added #on_weekend?, #next_weekday, #prev_weekday methods to Date,
+* Added #on_weekend?, #on_weekday?, #next_weekday, #prev_weekday methods to Date,
Time, and DateTime.
(Pull Request)

We can add this PR link (23687) in the release notes too. The PR 18335
doesn't add on_weekday.


Reply to this email directly or view it on GitHub
https://github.com/rails/rails/pull/23687/files#r52901426.

Vipul A.M.
+91-8149-204995

@vipulnsward

vipulnsward Feb 15, 2016

Member

Will do.

On Monday 15 February 2016, Vijay Dev notifications@github.com wrote:

In guides/source/5_0_release_notes.md
#23687 (comment):

@@ -705,7 +705,7 @@ Please refer to the [Changelog][active-support] for detailed changes.

  • Changed the default test order from :sorted to :random.
    (commit)

-* Added #on_weekend?, #next_weekday, #prev_weekday methods to Date,
+* Added #on_weekend?, #on_weekday?, #next_weekday, #prev_weekday methods to Date,
Time, and DateTime.
(Pull Request)

We can add this PR link (23687) in the release notes too. The PR 18335
doesn't add on_weekday.


Reply to this email directly or view it on GitHub
https://github.com/rails/rails/pull/23687/files#r52901426.

Vipul A.M.
+91-8149-204995

@vipulnsward vipulnsward deleted the vipulnsward:add-on-weekday branch Feb 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment