Remove http_cache_forever's version parameter #24072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
added a commit
that referenced
this pull request
Mar 5, 2016
Remove http_cache_forever's version parameter
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #18394
Summary
After a discussion with @jeremy and @rafaelfranca it seems we agree that the version parameter doesn't serve a real purpose and might actually mislead developers into thinking they can wipe the cache by bumping the version.
Context
Since
expires_in 100.yearssets aCache-Control: max-age=3155760000response header, browsers and / or proxy won't revalidate the resource back to the server unless they do a force-reload (Cache-Control: max-age=0request header). In which case the browser will receive the changed resource wether or not the ETag changed.If developers wish to wipe such cache, they will have to change the resource URL with a query parameter or similar.
cc @arthurnn