Fix TimeZone::MAPPING for 'Kyiv' #24375
Conversation
'Kyiv' is correct! It is translated from Ukrainian language. 'Kiev' is translated from Russian language this is not correct for Ukrainian. Ukraine is my home country.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @chancancode (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
See #22440 (comment) This list has been frozen for more changes. The change is also bound to be a breaking one for Apps depending on it. |
|
We can add it in changelog, to alert. |
| @@ -94,7 +94,7 @@ class TimeZone | |||
| "Bucharest" => "Europe/Bucharest", | |||
| "Cairo" => "Africa/Cairo", | |||
| "Helsinki" => "Europe/Helsinki", | |||
| "Kyiv" => "Europe/Kiev", | |||
| "Kyiv" => "Europe/Kyiv", | |||
There was a problem hiding this comment.
IANA timezone identifier is Europe/Kiev and you just can't change that in Rails. Please contact IANA first: https://www.iana.org/time-zones
There was a problem hiding this comment.
I have contacted to IANA. I am waiting reply.
There was a problem hiding this comment.
It was fixed in version 2022b https://mm.icann.org/pipermail/tz-announce/2022-August/000071.html
bogdanvlviv
changed the title
|
@rafaelfranca Could you please reopen this PR? I updated the PR description with recent changes on the ICANN side. |
|
Please please please! |
ICANN renamed
Europe/KievtoEurope/Kyivin2022b release, https://mm.icann.org/pipermail/tz-announce/2022-August/000071.html.
tzinfo/tzinfo-datagem updated to tzdata version 2022b, tzinfo/tzinfo-data@5a58dcb.Related to https://en.wikipedia.org/wiki/KyivNotKiev
The original request to ICANN: https://mm.icann.org/pipermail/tz/2016-April/023512.html