Gracefully fallback on version migrations for sqlite < 3.7.11 #24685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipulnsward
force-pushed
the
sqlite-compat-for-multi-insert
branch
from
a56ed2b
to
95851d7
Compare
|
@vipulnsward Your code is much nicer than that I'm working on. |
| "INSERT INTO #{sm_table} (version) VALUES ('#{version}');" | ||
| }.join "\n\n" | ||
| end | ||
|
|
There was a problem hiding this comment.
Splitting the insert methods means the caller is responsible for figuring out which to use. The caller is concerned with inserting versions, not with which insertion technique to use. Let's combine a single insert_versions(versions) for them to call:
def dump_schema_information
insert_versions_sql ActiveRecord::SchemaMigration.order('version').pluck(:version)
end
def insert_versions_sql(versions)
sm_table = ActiveRecord::Migrator.schema_migrations_table_name
if supports_multi_insert?
…
else
…
end
end
def assume_migrated_upto_version(version, migrations_paths)
…
execute insert_versions_sql(versions)
end
vipulnsward
force-pushed
the
sqlite-compat-for-multi-insert
branch
from
95851d7
to
961ac79
Compare
| @@ -29,6 +30,23 @@ def test_dump_schema_information_outputs_lexically_ordered_versions | |||
| ActiveRecord::SchemaMigration.delete_all | |||
| end | |||
|
|
|||
| if current_adapter?(:SQLite3Adapter) | |||
| %w{3.7.8 3.7.11 3.7.12}.each do |version_string| | |||
There was a problem hiding this comment.
Added check for different versions <, <=, >
vipulnsward
force-pushed
the
sqlite-compat-for-multi-insert
branch
from
961ac79
to
85345ef
Compare
| @@ -1026,7 +1047,7 @@ def assume_migrated_upto_version(version, migrations_paths) | |||
| if (duplicate = inserting.detect {|v| inserting.count(v) > 1}) | |||
| raise "Duplicate migration #{duplicate}. Please renumber your migrations to resolve the conflict." | |||
| end | |||
| execute "INSERT INTO #{sm_table} (version) VALUES #{inserting.map {|v| "('#{v}')"}.join(', ') }" | |||
| insert_versions(versions) | |||
vipulnsward
force-pushed
the
sqlite-compat-for-multi-insert
branch
from
85345ef
to
b95155b
Compare
This breaks for sqlite versions < 3.7.11, which is especially the case on Ubuntu 12.04 LTS, that has SQLite version 3.7.9 as default. So we check for support for multi insert, before performing single query inserts, else fallback to older version of running multiple queries. [Vipul A M & Yasuo Honda]
vipulnsward
force-pushed
the
sqlite-compat-for-multi-insert
branch
from
b95155b
to
6e09828
Compare
|
Done with the changes. |
jeremy
added a commit
that referenced
this pull request
Apr 22, 2016
…sert Gracefully fallback on version migrations for sqlite < 3.7.11
|
@jeremy thank you for the patient review! |
|
Thank you, @vipulnsward! 👏 |
|
@vipulnsward Thank you for working on this! ❤️ ❤️ ❤️ |
|
👏 |
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Apr 24, 2016
Follow up to rails#24685. `insert_versions_sql` is not public API.
|
It appears the fallback doesn't actually work and doesn't store all versions. See the output of this Travis run: https://travis-ci.org/publify/publify_core/builds/180931099, in particular the part where I list the migrations and the versions in the migrations table: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
42dd233 changed INSERT INTO versions to run in 1 single query.
This breaks for sqlite versions < 3.7.11, which is especially the case on Ubuntu 12.04 LTS, that has SQLite version 3.7.9 as default.
So we check for support for multi insert, before performing single query inserts, else fallback to older version of running multiple queries.