Followup to #24844 #24897
Merged
Followup to #24844 #24897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#24844 ? |
|
whoops, yeah. thanks @kamipo! let me update the commit message, and then I think this is ready to go (test are passing 👍 |
| @@ -93,8 +93,7 @@ def connection | |||
|
|
|||
| attr_writer :connection_specification_name | |||
|
|
|||
| # Return the specification id from this class otherwise look it up | |||
| # in the parent. | |||
| # Return the specification id from the current class or its parent. | |||
There was a problem hiding this comment.
s/specification id/specification name
| @@ -909,10 +909,11 @@ def remove_connection(spec_name) | |||
| # to optimise for. | |||
| def retrieve_connection_pool(spec_name) | |||
| owner_to_pool.fetch(spec_name) do | |||
| # Check if a connection was previously established in an ancestor process, | |||
| # which may have been worked. | |||
Some slight documentation edits and fixes. Also, run remove unnecessary `RuntimeError`. r? @arthurnn
|
updated per your comments, @jeremy. thanks for the review! :) |
|
thanks |
|
👍 thanks @arthurnn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some slight documentation edits and fixes. Also, run remove unnecessary
RuntimeError.r? @arthurnn