Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change comments to not exceed 80 characters #25076

Merged
merged 1 commit into from
May 21, 2016

Conversation

jeroenvisser101
Copy link
Contributor

When I create a new Rails 5 project and copy over my .rubocop.yml it complains about these lines being too long. All other files seem to keep to this limit. Other generated files do keep to this, but action cable doesn't.

Other generated files do keep to this, but action cable doesn't.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sikachu
Copy link
Member

sikachu commented May 19, 2016

I think this is a good change. 👍

@sikachu sikachu added the docs label May 19, 2016
@jeroenvisser101
Copy link
Contributor Author

@sikachu great :)

@jeroenvisser101
Copy link
Contributor Author

PS. I know about #13771 (comment), but I think this should be merged because it touches generated code, not Rails internals code.

@sgrif sgrif merged commit 26c0e2c into rails:master May 21, 2016
@jeroenvisser101
Copy link
Contributor Author

Thanks :)

@jeroenvisser101 jeroenvisser101 deleted the keep-to-max-length branch May 21, 2016 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants