Generate application_record.rb file before model file #25319
Merged
+20
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arthurnn (@rails-bot has picked a reviewer for you, use r? to override) |
morgoth
force-pushed
the
generate-application-record-first
branch
from
d803ad7
to
d627af8
Compare
Previously model file was generated first, which resulted in inheriting from `ActiveRecord::Base`, but since application_record.rb is generated as well, it should already be used.
morgoth
force-pushed
the
generate-application-record-first
branch
from
d627af8
to
b991017
Compare
|
What do you think about making it into 5.0? It would be a nice improvement for people upgrading. |
|
We already have a PR for that: #24756. |
|
I'll apply both |
|
Thanks. I didn't notice the first one |
rafaelfranca
added a commit
that referenced
this pull request
Jun 13, 2016
Generate application_record.rb file before model file
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously model file was generated first, which resulted in
inheriting from
ActiveRecord::Base, but since application_record.rbis generated as well, it should already be used.