Set counter caches to correct values in fixtures #25346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
bogdan
force-pushed
the
correct-tags-count-in-fixtures
branch
2 times, most recently
from
c38da2e
to
776878f
Compare
bogdan
changed the title
bogdan
force-pushed
the
correct-tags-count-in-fixtures
branch
from
776878f
to
d87822e
Compare
bogdan
force-pushed
the
correct-tags-count-in-fixtures
branch
2 times, most recently
from
bcb0dfc
to
e51108c
Compare
bogdan
force-pushed
the
correct-tags-count-in-fixtures
branch
2 times, most recently
from
1325239
to
6bf1ec5
Compare
|
@sgrif can you please review this one? It blocks some interesting patches I want accomplish. |
bogdan
force-pushed
the
correct-tags-count-in-fixtures
branch
from
6bf1ec5
to
bf0772a
Compare
|
@pixeltrix can you review this one? I have some interesting work that is blocked by an inconsistency in test suite data. |
|
@bogdan can you fix the rubocop issue - thanks! |
bogdan
force-pushed
the
correct-tags-count-in-fixtures
branch
from
bf0772a
to
ae6361b
Compare
kamipo
pushed a commit
that referenced
this pull request
Dec 20, 2017
Set counter caches to correct values in fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I tried to make a patch in AR that suppose to fix an issue, but some of tests started to fail because posts fixtures counter caches are set incorrectly and invalid data is put into database. So this patch just sets right fixture values to the right value for all fixtures.