Always store errors details information with symbols #26552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
force-pushed
the
fix-errors-details-storage
branch
2 times, most recently
from
a38be31
to
9c8d76a
Compare
When the association is autosaved we were storing the details with string keys. This was creating inconsistency with other details that are added using the `Errors#add` method. It was also inconsistent with the `Errors#messages` storage. To fix this inconsistency we are always storing with symbols. This will cause a small breaking change because in those cases the details could be accessed as strings keys but now it can not. The reason that we chose to do this breaking change is because `#details` should be considered a low level object like `#messages` is. Fix rails#26499. [Rafael Mendonça França + Marcus Vieira]
rafaelfranca
force-pushed
the
fix-errors-details-storage
branch
from
9c8d76a
to
d406014
Compare
|
@matthewd are you fine with backporting this to 5-0-stable? |
|
👍 |
rafaelfranca
added a commit
that referenced
this pull request
Sep 20, 2016
Always store errors details information with symbols
|
Backported in ac0c589 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the association is autosaved we were storing the details with string keys. This was creating inconsistency with other details that are added using the
Errors#addmethod. It was also inconsistent with theErrors#messagesstorage.To fix this inconsistency we are always storing with symbols. This will cause a small breaking change because in those cases the details could be accessed as strings keys but now it can not.
Fix #26499.
[Rafael Mendonça França + Marcus Vieira]