don't create db directory when skip active_record

[zegomesjf]

Hey all,

Actual behavior/Motivation

when using rails new my-app --skip-active-record

The db directory is created with seeds.rb file inside it.

and also because, the rails db:seed command doesn't work

$ rails db:seed
rails aborted!
Don't know how to build task 'db:seed' (see --tasks)

Expected behavior

I would not expect the db directory to exist

System configuration

Rails version: 5.0.0.1

Ruby version: 2.3.1

[guilleiguaran]

What the command rails db:seed does after of applying this patch?

[zegomesjf]

@guilleiguaran thanks to review,

the behaviour was not affected on this command, but I mean the seeds.rb file contains:

# This file should contain all the record creation needed to seed the database with its default values.
# The data can then be loaded with the rails db:seed command (or created alongside the database with db:setup).
#
# Examples:
#
#   movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }])
#   Character.create(name: 'Luke', movie: movies.first)

it gives the impression that the command should work.

[guilleiguaran]

@zegomesjf ah cool, thanks 👍

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.