Use Hash#compact and Hash#compact! from Ruby 2.4

[prathamesh-sonpatki]

Summary

• Ruby 2.4 has added Hash#compact and Hash#compact! so we can use it
  now.
• Reference: https://bugs.ruby-lang.org/issues/11818 and https://bugs.ruby-lang.org/issues/12863.

r? @rafaelfranca

[vipulnsward]

This should be an explicit check on Hash.instance_methods(false), not sure how the behaviour would be with Hash inherited classes.

[prathamesh-sonpatki]

What is the difference between this and explicit check?

[vipulnsward]

class Hash
  def puts_self
    puts "Self#{self.class}"
  end
end


class HashImp < Hash

end


HashImp.new.puts_self

=> SelfHashImp

The self picks up the current class. Again, not sure about the implications, its better to be explicit.

[vipulnsward]

Needs CHANGELOG like vipulnsward@7ad4690
to indicate the change it ruby 2.4+

[prathamesh-sonpatki]

I did not add changelog because this change is compatible with AS. So no change in public consumption of these methods unlike Enumerable#sum.

[vipulnsward]

I did not add changelog because this change is compatible with AS. So no change in public
consumption of these methods unlike Enumerable#sum.

Ideally it would good that they are same, but if there are any differences/bugs that we find in future, it is good to mention what has changed.

[seuros]

@prathamesh-sonpatki I think we can test just once , because the language either implement both or none.

  unless Hash.instance_methods(false).include?(:compact)
   class Hash
      def compact
      # code here
      def compact!
      #code here....

[vtrkanna]

Is this part of ruby 2.4 or rails 5 ?

[rafaelfranca]

both

[kaspth]

Active Support has shipped with Hash#compact since 4.2, this just uses Ruby's built in methods when they come out in 2.4 (so Ruby upgrading users will get the faster version).

[prathamesh-sonpatki]

Ruby 2.4

[kaspth]

Jinx! @prathamesh-sonpatki @rafaelfranca 😁