Fixes bug in ActiveRecord::QueryMethods, #1697 #2775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace split on comma with a regexp that will reverse all ASC/DESC specifically
#1697 says it was fixed, but that fix was reverted in 971a74b. It seems likely 18d307e was failing on Travis because MAX (the function used in the test scenario) does not actually accept multiple arguments on MySQL.