Include selects in group query with having clause #28183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a grouped calculation contains a having clause that references a selected value, we need to include that selected value in the query. Postgres doesn't support referencing a selected value in a having clause, but other databases do; we can skip the test on the pg adapter but run it for the others. This was fixed before in 9a298a1, but the test coverage was lost in 5a05207. The fix regressed in 6311975 and was removed in 97d46c1.
|
@eugeneius good catch - I didn't read the intent of the query correctly |
|
Thanks for the quick review! 👍 I assumed the same thing as you initially -- that the test proved that some other code was now covering the same functionality -- but I was curious enough to try running a query... |
|
Backported to 5-0-stable and and 4-2-stable - thanks again @eugeneius |
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a grouped calculation contains a having clause that references a selected value, we need to include that selected value in the query.
Postgres doesn't support referencing a selected value in a having clause, but other databases do; we can skip the test on the pg adapter but run it for the others.
This was fixed before in #1969, but the test coverage was lost in 5a05207. The fix regressed in 6311975 and was removed in #28179.
r? @pixeltrix
/fyi @kamipo