Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update `DateTime#change` to support usec and nsec #28242

Merged
merged 1 commit into from Mar 2, 2017

Conversation

@pixeltrix
Copy link
Member

pixeltrix commented Mar 1, 2017

Adding support for these options now allows us to update the DateTime#end_of methods to match the equivalent Time#end_of methods, e.g:

datetime = DateTime.now.end_of_day
datetime.nsec == 999999999 # => true

Fixes #21424.

Adding support for these options now allows us to update the
`DateTime#end_of` methods to match the equivalent `Time#end_of`
methods, e.g:

    datetime = DateTime.now.end_of_day
    datetime.nsec == 999999999 # => true

Fixes #21424.
@pixeltrix pixeltrix force-pushed the add-fractional-support-to-datetime-change branch from 495bde7 to b5af751 Mar 2, 2017
@pixeltrix pixeltrix merged commit a815c7c into master Mar 2, 2017
3 checks passed
3 checks passed
codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@pixeltrix pixeltrix deleted the add-fractional-support-to-datetime-change branch Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.