New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate an `capify!` method in generators and templates #29493

Merged
merged 1 commit into from Jun 19, 2017

Conversation

Projects
None yet
5 participants
@y-yagi
Member

y-yagi commented Jun 18, 2017

The capify command has been removed by Capistrano 3 and became to cap install.
Therefore, the capify! method has no meaning in Capistrano 3.
I think that should deprecate.

Ref: capistrano/capistrano@4927939

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Jun 18, 2017

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

rails-bot commented Jun 18, 2017

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

Show outdated Hide outdated railties/CHANGELOG.md
Deprecate an `capify!` method in generators and templates
The `capify` command has been removed by Capistrano 3 and became to
`cap install`.
Therefore, the `capify!` method has no meaning in Capistrano 3.
I think that should deprecate.

Ref: capistrano/capistrano@4927939

@rafaelfranca rafaelfranca merged commit c6d19fc into rails:master Jun 19, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate no new or fixed issues
Details

@y-yagi y-yagi deleted the y-yagi:deprecate_capify branch Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment