New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `railtie.rb` to the plugin generator #29576

Merged
merged 1 commit into from Jun 26, 2017

Conversation

Projects
None yet
4 participants
@ttanimichi
Contributor

ttanimichi commented Jun 26, 2017

Before

$ rails plugin new myplugin
$ ls myplugin/lib/myplugin
version.rb

After

$ rails plugin new myplugin
$ ls myplugin/lib/myplugin
railtie.rb  version.rb

$ cat myplugin/lib/myplugin/railtie.rb
module Myplugin
  class Railtie < ::Rails::Railtie
  end
end

ref. http://api.rubyonrails.org/classes/Rails/Railtie.html

@rails-bot

This comment has been minimized.

rails-bot commented Jun 26, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit ceedecd into rails:master Jun 26, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codeclimate no new or fixed issues
Details

@ttanimichi ttanimichi deleted the ttanimichi:add-railtie-rb branch Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment