Deprecate database specific JSON types #29666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those classes are nodoc so they can be removed without deprecation. |
We already have database agnostic `Type::Json` since rails#29220.
kamipo
force-pushed
the
deprecate_database_specific_json_types
branch
from
d210ed3
to
2568414
Compare
|
Indeed. I changed to remove the database specific types. |
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Jun 25, 2020
…version: 1` We had removed the dedicated `MysqlDateTime`, `MysqlJson`, and `OID::Json` classes in the past (f1a0fa9, rails#29666), so legacy YAML loading has no longer always perfectly compatiblity. Fortunately, v2 (Rails 5.1 style) YAML doesn't contain type information in almost all cases (unless serializing object using custom select), so usually removing dedicated type affects to legacy YAML older than v1 (Rails 5.0 style) YAML only. This restores legacy YAML compatibility for MySQL with v1 format by adding the class alias in YAML for `MysqlString` which is most recently reported about compatibility concern. It also affects to legacy Rails 4.2 style YAML, but 4.2 style YAML had already broken by removing `MysqlDateTime` over 4 years ago.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Jun 30, 2020
… MySQL Context rails#39599 (comment). Similar with rails#39611. Actually we never said we would keep Mashal compatibility between two versions of Rails, so we sometimes directly removed the dedicated types in the past (e.g. f1a0fa9, rails#29666), but that direct removing makes cache rotation harder. Keeping the unused constant in new version at least during one version will help cache rotation easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have database agnostic
Type::Jsonsince #29220.