Backport new constant for Marshal.load(record.dump)
forward compatibility
#39769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of backporting #39612 is for
Marshal.load(record.dump)
forward compatibility.
Actually we never said we would keep Mashal compatibility between two
versions of Rails, so we sometimes directly added and removed the
internal objects. Theoretically, removing objects will lose backward
compatibility and adding objects will lose forward compatibility.
Example:
MysqlDateTime
f1a0fa9SQLite3Integer
SQLite3 valid integer value should be 8 bytes (64-bit signed integer) #28379Type::Json
and removedMysqlJson
/OID::Json
Deprecate database specific JSON types #29666I'm not sure how much we should be aware of
Mashal.load
compatibility.Especially if we should keep perfectly forward compatibility, we almost
have no chance to improve object layout (includes ivar usage).
One possible idea to mitigate breaking forward compatibility is
backporting new constant to the latest stable branch.