Update rack-test dependency constraint #29859
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
actionpack/actionpack.gemspec
Outdated
| @@ -27,7 +27,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency "activesupport", version | |||
|
|
|||
| s.add_dependency "rack", "~> 2.0" | |||
| s.add_dependency "rack-test", "~> 0.6.3" | |||
| s.add_dependency "rack-test", "~> 0.7.0" | |||
There was a problem hiding this comment.
Is there any reason to disallow 0.6.3? If not this should be s.add_dependency "rack-test", ">= 0.6.3"
There was a problem hiding this comment.
Nope, that's fair - updated. Thank you.
|
Cloud you squash your commits? |
|
Of course, done. |
Update rack-test dependency constraint
|
This is not part of 5.1.3 😞 |
|
@mvz why do you need it in 5.1? Is there anything in rack-test that require us to backport? |
|
@rafaelfranca only for the reason given for this PR:
|
|
Done |
Update rack-test dependency constraint
|
Awesome, thanks! |
|
This caused regression in new release #30570 because of rack/rack-test#200 |
Backport [rails#29859](rails#29859) to enable rack-test upgrades. `Rack-test` is by far our oldest dependency and is pinned by our Rails version. Given that we've forked Rails anyways, we may as well loosen this constraint of this test dependency (which has been done on Rails master anyways since Rails 5.2).
Summary
This updates the dependency constraint for
rack-testinactionpack.rack-testis the only gem that appears as outdated when runningbundle outdatedon a fresh installation of Rails.I've checked the changelog for
rack-testand it doesn't appear to have breaking changes, and theactionpacktests passed locally for me after the change.Other Information
This is my first Rails PR so I hope I'm doing it right - wasn't sure whether I should commit the updated
Gemfile.lockas well or if I needed to update the changelog. Happy to be pointed in the right direction for any changes.