42 compatibility - use int instead of bigint

[ahorek]

Summary

class AddProjectsWithSettings < ActiveRecord::Migration[4.2]
    create_table :projects

    create_table :settings do |t|
      t.references :project, index: true, foreign_key: true
    end
end

creating a reference fails, because default primary key type for version [4.2] is an integer, but references tries to use a bigint

master

projects.id => :integer
settings.project_id => :bigint

expected

projects.id => :integer
settings.project_id => :integer

Rails version
4.2.x - ok
5.1.4 - ok
master - fails

Other Information

related commit
14db455#diff-21d4fbe002689dc4b0ab29f021585457

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

[kamipo]

Originally I intended to prepend both compatible TableDefinition.
Can you change the fix like here?

--- a/activerecord/lib/active_record/migration/compatibility.rb
+++ b/activerecord/lib/active_record/migration/compatibility.rb
@@ -171,7 +171,7 @@ def compatible_table_definition(t)
             class << t
               prepend TableDefinition
             end
-            t
+            super
           end
 
           def index_name_for_remove(table_name, options = {})