Add support for connection pooling on RedisCacheStore #31866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@rails-bot has picked a reviewer for you, use r? to override) |
rafaelfranca
added a commit
that referenced
this pull request
Feb 14, 2018
Add support for connection pooling on RedisCacheStore
rafaelfranca
added a commit
that referenced
this pull request
Feb 14, 2018
Add support for connection pooling on RedisCacheStore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was merged and then reverted due to a bug for
Redis::Distributedin #31447.I changed implementation to also match
MemCacheStore's pool implementation for sharded data and added missing test.Also looks like this will have problems with already instantiated redis object, passed from user, which we obviously cannot use within connection pool to instantiate new redis objects from it. So some warning or error should be raised?
Can you @georgeclaghorn and @rafaelfranca please review once again?