New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for connection pooling on RedisCacheStore #31866

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
4 participants
@fatkodima
Contributor

fatkodima commented Feb 1, 2018

This was merged and then reverted due to a bug for Redis::Distributed in #31447.

I changed implementation to also match MemCacheStore's pool implementation for sharded data and added missing test.
Also looks like this will have problems with already instantiated redis object, passed from user, which we obviously cannot use within connection pool to instantiate new redis objects from it. So some warning or error should be raised?

Can you @georgeclaghorn and @rafaelfranca please review once again?

@rails-bot

This comment has been minimized.

rails-bot commented Feb 1, 2018

r? @georgeclaghorn

(@rails-bot has picked a reviewer for you, use r? to override)

rafaelfranca added a commit that referenced this pull request Feb 14, 2018

Merge pull request #31866 from fatkodima/redis_cache-connection_pool
Add support for connection pooling on RedisCacheStore

@rafaelfranca rafaelfranca merged commit dc40739 into rails:master Feb 14, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate All good!
Details

rafaelfranca added a commit that referenced this pull request Feb 14, 2018

Merge pull request #31866 from fatkodima/redis_cache-connection_pool
Add support for connection pooling on RedisCacheStore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment