Change temporary file name extension while editing encrypted file. #32268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@rails-bot has picked a reviewer for you, use r? to override) |
kaspth
reviewed
Mar 18, 2018
| @@ -57,7 +57,7 @@ def change(&block) | |||
|
|
|||
| private | |||
| def writing(contents) | |||
| tmp_file = "#{content_path.basename}.#{Process.pid}" | |||
| tmp_file = "#{Process.pid}.#{content_path.basename.sub(/\.enc$/, '')}" | |||
There was a problem hiding this comment.
chomp(".enc") seems pertinent 😊
There was a problem hiding this comment.
Done. Had to add to_s as we're dealing here with Pathname object, which has sub method, but no chomp
To have syntax highlighting in an editor try to preserve original extension of edited file.
morgoth
force-pushed
the
encrypted-tmp-file-name
branch
from
e15f840
to
902b6e2
Compare
|
r? @kaspth |
|
@kaspth can it be merged? I think it would be a nice improvement in 5.2 release |
|
Yep, I was just working through my list now! Thanks! |
kaspth
added a commit
that referenced
this pull request
Apr 1, 2018
Change temporary file name extension while editing encrypted file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have syntax higlihting in an editor try to preserve original extension of edited file