Fix: FileStoreTest#test_filename_max_size fails in Ruby 2.5.1

[utilum]

Summary

As of Tmpname.create was changed in ruby/ruby@10b9690 to return a 'path' purged of file separators. The result is a test failure, even though the actual basename respects the constraint:

FileStoreTest#test_filename_max_size [/rails/activesupport/test/cache/stores/file_store_test.rb:72]:
Temp filename too long: 297

Other Information

$ ruby -v
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]

[rails-bot]

r? @kaspth

(@rails-bot has picked a reviewer for you, use r? to override)

[pixeltrix]

@utilum we can fix this in a better way by using the second argument to Dir::Tmpname.create, e.g:

def test_filename_max_size
  key = "#{'A' * ActiveSupport::Cache::FileStore::FILENAME_MAX_SIZE}"
  path = @cache.send(:normalize_key, key, {})
  basename = File.basename(path)
  dirname = File.dirname(path)

  Dir::Tmpname.create(basename, Dir.tmpdir + dirname) do |tmpname, n, opts|
    assert File.basename(tmpname + ".lock").length <= 255, "Temp filename too long: #{File.basename(tmpname + '.lock').length}"
  end
end

That way we're not changing the asserted value

[pixeltrix]

@utilum don't worry - I manually edited your commit and merged it in 0548d65. Thanks for spotting the error! 👍