Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed undefined method `second' in FormOptionsHelperTest #3245

Closed
wants to merge 1 commit into from

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented Oct 7, 2011

No description provided.

@arunagw
Copy link
Member

arunagw commented Oct 7, 2011

@yahonda did you check functionality after removing this?? Actually the original commit was not having tests with it!

I think a good test is required here!

@arunagw
Copy link
Member

arunagw commented Oct 7, 2011

Oops actually it was having 587dd7d

Are these tests passing ??

@yahonda
Copy link
Member Author

yahonda commented Oct 7, 2011

These tests passed with my commit as follows. I can say my fix does not break others.
Of course, it might not be the best way to fix that. as I said.

$ cd actionpack
$ ruby -w -I"lib:test" -I"/home/yahonda/.rvm/gems/ruby-1.9.3-rc1@rails_master/gems/rake-0.9.3.beta.1/lib" "/home/yahonda/.rvm/gems/ruby-1.9.3-rc1@rails_master/gems/rake-0.9.3.beta.1/lib/rake/rake_test_loader.rb"  "test/template/form_options_helper_test.rb"
Run options:

# Running tests:

.................................................................................................

Finished tests in 2.027000s, 47.8540 tests/s, 52.7874 assertions/s.

97 tests, 107 assertions, 0 failures, 0 errors, 0 skips

@spastorino
Copy link
Contributor

@tenderlove already fixed it

@spastorino spastorino closed this Oct 8, 2011
@yahonda
Copy link
Member Author

yahonda commented Oct 8, 2011

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants