New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations will raise an exception if there are multiple column defin… #33029

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
5 participants
@fedxgibson
Contributor

fedxgibson commented May 31, 2018

Migrations raise exception when defining already defined column.

TableDefinition#column checks if there is already a column defined with the same name. In this case it will raise an exception.

@rails-bot

This comment has been minimized.

rails-bot commented May 31, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@a7madM

a7madM approved these changes Jun 1, 2018

@eileencodes eileencodes merged commit c4c8e35 into rails:master Jun 4, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eileencodes

This comment has been minimized.

Member

eileencodes commented Jun 4, 2018

Thanks for fixing this! 🎉

@fedxgibson

This comment has been minimized.

Contributor

fedxgibson commented Jun 7, 2018

Glad to help! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment