Add allocations to template renderer subscription #34136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
force-pushed
the
add-allocations-to-template-renderer
branch
from
69a33bc
to
0571e18
Compare
| @@ -20,12 +20,15 @@ def process_action(event) | |||
| info do | |||
| payload = event.payload | |||
| additions = ActionController::Base.log_process_action(payload) | |||
|
|
|||
| status = payload[:status] | |||
There was a problem hiding this comment.
Nitpick: After removing the blank line I would format status to the same level asadditions as we seem to follow that style across this file.
payload = event.payload
additions = ActionController::Base.log_process_action(payload)
status = payload[:status]There was a problem hiding this comment.
I went the other way. Evening the space makes searching harder so I'm not a huge fan.
There was a problem hiding this comment.
Great! Thanks for caring about this and for the PR ❤️
This PR adds the allocations to the instrumentation for template and partial rendering. Before: ``` Rendering posts/new.html.erb within layouts/application Rendered posts/_form.html.erb (9.7ms) Rendered posts/new.html.erb within layouts/application (10.9ms) Completed 200 OK in 902ms (Views: 890.8ms | ActiveRecord: 0.8ms) ``` After: ``` Rendering posts/new.html.erb within layouts/application Rendered posts/_form.html.erb (Duration: 7.1ms | Allocations: 6004) Rendered posts/new.html.erb within layouts/application (Duration: 8.3ms | Allocations: 6654) Completed 200 OK in 858ms (Views: 848.4ms | ActiveRecord: 0.4ms | Allocations: 1539564) ```
eileencodes
force-pushed
the
add-allocations-to-template-renderer
branch
from
0571e18
to
e8c1be4
Compare
|
Since this uses GC.stat, do we care that this will throw out potentially nonsense numbers for multithreaded application servers like Puma? Should this be turned off or somehow warning-flagged in those environments? |
|
@tenderlove @eileencodes forgot to tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the allocations to the instrumentation for template and
partial rendering.
Before:
After:
cc/ @tenderlove